Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in infos-list with alias display (touchable area, icon, tune) #813

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to fix minor issues in infos-list with alias display:

  • whole row as touchable area
  • chevron icon
  • tune when coming back from info list

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.76%. Comparing base (afadb33) to head (f21ade2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   35.76%   35.76%           
=======================================
  Files          13       13           
  Lines        1591     1591           
=======================================
  Hits          569      569           
  Misses       1022     1022           
Flag Coverage Δ
unittests 35.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdejoigny-ledger
Copy link
Contributor

tdejoigny-ledger commented Oct 22, 2024

@nroggeman-ledger
tested --> on speculos & Flex --> 🟢

@nroggeman-ledger nroggeman-ledger merged commit 0aad933 into master Oct 23, 2024
184 checks passed
@nroggeman-ledger nroggeman-ledger deleted the minor-fix-in-info-list-with-alias branch October 23, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants